-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reference Type Warnings #1142
Open
Yey007
wants to merge
44
commits into
m4rs-mt:master
Choose a base branch
from
Yey007:feature/reftype-analyzer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yey007
force-pushed
the
feature/reftype-analyzer
branch
from
February 20, 2024 19:49
2973b2f
to
6b65d8d
Compare
…lysis up to implementers.
- Analyzer now ignores only unmanaged types, not value types - Analyzer now ignores ILGPU types - Additional tests for this new behavior - Change test folder structure
Yey007
force-pushed
the
feature/reftype-analyzer
branch
from
March 30, 2024 04:25
e513d84
to
4c00f4e
Compare
m4rs-mt
requested changes
Apr 14, 2024
Src/ILGPU.Analyzers.Tests/Programs/ManagedType/ILGPUTypesIntrinsics.cs
Outdated
Show resolved
Hide resolved
…nterfaceMembers sample.
m4rs-mt
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you very much for your amazing contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1120 based on the work @MoFtZ has already done in #982 (many thanks!). As such, it depends on #982. I'm holding off on making too many changes before we finalize a project structure. I am happy to talk in this regard!